8368467: [lworld] Add new flag generation for jimage to support preview mode #1621

david-beaumont · 2025-09-23T19:25:22Z

Adds support for writing preview related flags into jimage files.

Preview mode is complex. It's not nearly as simple as "does something in /modules/xxx/... have an entry in /modules/xxx/META-INF/preview/...".

Specific issues include:

Supporting preview-only resources without forcing a double lookup on everything.
Changing the set of entries in /packages/xxx directories to account for preview only packages in some modules.
Minimising the work done during image reader initialization to only need to process the small number of preview resources (rather than scanning the whole file to look for them).
The new flags added by this code address these issues, but calculating them correctly with only minor adjustments to the existing code was not feasible, it just became a lot larger and very complex.

To address this, a new type (ModuleReference) is introduced to track and then merge information about packages seen in each module. This allows a much simpler inner loop for processing resource paths when building the node tree, combined with a subsequent merging stage to produce the final package information for each module.

Not that since ModuleReference is needed during jimage reading, that class is already present in the previous PR on which this is based, but it starts to be used to calculate the module flags in this PR.

This PR can also adds the ImageReader unit tests for preview mode, which rely on being able to generate jimage files with preview mode flags in.

Compare and review this against #1619.

Progress

Change must not contain extraneous whitespace

Integration blocker

⚠️ Dependency #1619 must be integrated first

Issue

JDK-8368467: [lworld] Add new flag generation for jimage to support preview mode (Sub-task - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1621/head:pull/1621
$ git checkout pull/1621

Update a local copy of the PR:
$ git checkout pull/1621
$ git pull https://git.openjdk.org/valhalla.git pull/1621/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1621

View PR using the GUI difftool:
$ git pr show -t 1621

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1621.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2025-09-23T19:27:32Z

👋 Welcome back david-beaumont! A progress list of the required criteria for merging this PR into pr/1619 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-09-23T19:29:18Z

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

mlbridge · 2025-09-23T19:32:20Z

Webrevs

david-beaumont · 2025-09-23T20:16:18Z

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImageFileCreator.java

        return resultResources;
    }

+    private static ResourcePool getResourcePool(


Pulled out so the variable holding it is effectively final and can be used in a lambda expression.

david-beaumont · 2025-09-23T20:17:14Z

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImageLocationWriter.java

-               .addAttribute(ATTRIBUTE_OFFSET, contentOffset)
-               .addAttribute(ATTRIBUTE_COMPRESSED, compressedSize)
-               .addAttribute(ATTRIBUTE_UNCOMPRESSED, uncompressedSize);
+                .addAttribute(ATTRIBUTE_MODULE, moduleName)


This got reformatted correctly to 8 indent because of the new entry.

david-beaumont · 2025-09-23T20:18:48Z

test/jdk/tools/jlink/whitebox/jdk.jlink/jdk/tools/jlink/internal/ImageResourcesTreeTest.java

+        assertEquals(PKG_FLAG_IS_PREVIEW_ONLY, emptyRef.flags());
+    }
+
+    @Test


This test needs updating. The order of the entries has changed. Sorry for not spotting sooner.

Actually I had fixed this locally and somehow it hadn't got patched into this PR. Updated now and the test compiles and passes.

david-beaumont · 2025-09-23T20:25:49Z

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImageResourcesTree.java

+            // later be merged with a non-empty reference for the same package.
+            ModuleReference emptyRef = ModuleReference.forEmptyPackage(modName, isPreviewPath);
+
+            // Work down through empty packages to final resource.


This loop and the section after replaces the logic between L191 and L238 in the original code.

Instead of two maps (which would be 4 if we tried to add preview support that way) with near-duplicated logic, there's now just "walk down the path creating empty package nodes until the last segment is reached, then exit and create the resource node in a non-empty package".

The empty/non-empty/preview nature of these packages is all handled when the module references are merged later, but for now they are independent.

david-beaumont · 2025-09-23T20:29:02Z

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImageResourcesTree.java

+            packageToModules.keySet().removeIf(p -> p.isEmpty() || p.equals("META-INF") || p.startsWith("META-INF."));
+            packageToModules.forEach((pkgName, modRefs) -> {
+                // Merge multiple refs for the same module.
+                List<ModuleReference> pkgModules = modRefs.stream()


This is where module references are merged so each package has the right set of flags according to all the resources visited in the module (empty, non-empty, preview, preview-only...). This replaces the use of the two maps (moduleToPackage and packageToModule) and a bunch of other logic.

david-beaumont · 2025-09-23T20:30:14Z

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImageResourcesTree.java

+                List<ModuleReference> refs = pkgNode.getModuleReferences();
+                ByteBuffer byteBuffer = ByteBuffer.allocate(8 * refs.size());
+                byteBuffer.order(writer.getByteOrder());
+                ModuleReference.write(refs, byteBuffer.asIntBuffer(), writer::addString);


Call into the ModuleReference code added in the previous PR to write the package flags and offsets.

david-beaumont · 2025-09-23T20:34:28Z

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImageResourcesTree.java

+     * <p>While there are 8 combinations of these 3 flags, some will never
+     * occur (e.g. {@code HAS_NORMAL_CONTENT + IS_PREVIEW_ONLY}).
+     *
+     * <p>Package node entries are sorted by name, with the exception that (if


This is out of date (along with the test). It's now sorted "preview first" and then "by name". The reason for the change is that I had made an incorrect assumption that I didn't need to process empty packages from preview resources, but I do (they still appear in /packages/xxx directories).

openjdk · 2025-09-23T23:04:15Z

@david-beaumont Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

RogerRiggs · 2025-09-26T01:40:47Z

src/java.base/share/classes/jdk/internal/jimage/ImageLocation.java

-                // TODO: Uncomment the FLAGS_IS_PACKAGE_ROOT test below.
-                // return (getFlags() & FLAGS_IS_PACKAGE_ROOT) != 0
-                return getBase().charAt(1) == 'p'
+                return (getFlags() & FLAGS_IS_PACKAGE_ROOT) != 0


Introducing a flag bit that is carried around in lots of entries but applies to only one is overkill.
The simple test above for the first letter is cleaner and very localized.

RogerRiggs · 2025-09-26T19:30:11Z

src/java.base/share/classes/jdk/internal/jimage/PreviewMode.java

+            if (!ENABLE_PREVIEW_MODE) {
+                return false;
+            }


As commented in the 1618 PR, the extra subclasses caused by the overrides can be replaced by the resolve method switching on ordinal().

Great idea, thanks.

RogerRiggs · 2025-09-26T19:35:07Z

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImageLocationWriter.java

-            ImageStringsWriter strings,
-            long contentOffset, long compressedSize, long uncompressedSize) {
+                                           ImageStringsWriter strings,
+                                           long contentOffset, long compressedSize, long uncompressedSize, int previewFlags) {


Wrap or untab to avoid long lines.

RogerRiggs · 2025-09-26T20:26:52Z

test/jdk/jdk/internal/jimage/ImageReaderTest.java

            "/modules/modfoo/com/foo/bar"})
    public void testModuleDirectories_expected(String name) throws IOException {
-        try (ImageReader reader = ImageReader.open(image)) {
+        try (ImageReader reader = ImageReader.open(image, PreviewMode.DISABLED)) {


The image variable might be better documented in upper case to make it easier to see its a pre-computed value.

openjdk · 2025-10-10T11:03:20Z

⚠️ @david-beaumont This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

david-beaumont · 2025-10-10T11:30:19Z

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/BasicImageWriter.java


-    private ByteOrder byteOrder;
-    private ImageStringsWriter strings;
+    private final ByteOrder byteOrder;


Made obvious fields final and removed unused, non-public, code.

…orSize=8 Reviewed-by: dzhang, epeter, rrich

Reviewed-by: tschatzl, dholmes

…odyPublishers.noBody() Reviewed-by: dfuchs, vyazici

Reviewed-by: lkorinth, cstein, jpai, syan, serb, prr

Reviewed-by: cjplummer, pchilanomate

…ent cpu extensions/flags Reviewed-by: fyang, luhenry

…Expressions.java fails with ArithmeticException: / by zero - forgot to respect Expression.info Reviewed-by: kvn, mhaessig

…nd must be greater than origin Reviewed-by: chagedorn, thartmann

…ature part of method patterns Reviewed-by: rcastanedalo, aseoane, thartmann

…sInCustomFileSystem.java Reviewed-by: alanb, syan

Reviewed-by: alanb, liach, bpb

…ct.java timed out Reviewed-by: dfenacci, epeter

Reviewed-by: rriggs, iris, lancea

…nd should be removed Reviewed-by: sspitsyn, amenkov

….properties Reviewed-by: azvegint, kizune

…alid or unrecognized bugid: 50510568367702 Reviewed-by: syan, azvegint, kizune, jdv

…int that intervenes between allocation and stores Reviewed-by: ysr

Reviewed-by: darcy, shade, ihse, iris

openjdk · 2025-10-27T12:51:52Z

@david-beaumont Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

david-beaumont · 2025-10-27T13:18:49Z

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImageResourcesTree.java

-                    PackageNode pkgNode = new PackageNode(pkg, packages);
-                    pkgNode.addReference(entry.getKey(), false);
-                    directAccess.put(pkgNode.getPath(), pkgNode);
+                    // invalid directory entry marked as not directory (see 8131762).


I'm not 100% sure of the value of retaining stderr logging like this, especially if the code continues after ignoring the input, but it's the same behaviour as before, so I'm leaving it as-is.

david-beaumont · 2025-10-27T13:20:26Z

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImageResourcesTree.java

+            String resourceName = pkgPath.substring(pathEnd + 1);
+            // Intermediate packages are marked "empty" (no resources). This might
+            // later be merged with a non-empty reference for the same package.
+            ModuleReference emptyRef = ModuleReference.forEmptyPackageIn(modName, isPreviewPath);


This convinces me that forEmptyPackageIn is a better name than forEmptyPackage, since the passing of the module name as the first parameter no longer raises eyebrows.

david-beaumont · 2025-10-27T13:22:37Z

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImageResourcesTree.java

+            if (resourceNode == null) {
+                ModuleReference resourceRef = ModuleReference.forPackageIn(modName, isPreviewPath);
+                packageToModules.computeIfAbsent(fullPkgName, p -> new HashSet<>()).add(resourceRef);
+                // Init adds new node to parent (don't add resources to directAccess).


I'd be happy to rename the directAccess field. It's really a holder for directories. The fact it's "direct access" is rather a statement of its form (obvious since it's a map really) and not its function.
Thoughts?

david-beaumont · 2025-10-27T13:25:56Z

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImageResourcesTree.java

-                return path;
-            } else {
-                return path.substring(0, i);
+        // Helper to iterate package names up to, and including, the complete name.


If this comment isn't clear enough I can elaborate. Basically lets you iterate indices in "foo.bar.baz" as 3, 7, 11, -1 (including an index at the end of the string before it returns -1). This is just here to make the for-loop cleaner where the real business logic is.

david-beaumont · 2025-10-27T13:27:23Z

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImageResourcesTree.java

        }

-        public String removeRadical(Node node) {
+        private String removeRadical(Node node) {


I don't think this method obviously earns its keep, so would be happy to inline it, perhaps with a string constant. But also happy to leave it.

david-beaumont · 2025-10-27T13:29:08Z

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImageResourcesTree.java

                        // A resource location, remove "/modules"
                        String s = tree.toResourceName(current);
-                        current.loc = outLocations.get(s);
+                        current.setLocation(outLocations.get(s));


Calling this via the method adds a check that nothing is being overwritten.

david-beaumont · 2025-10-27T13:34:24Z

test/jdk/jdk/internal/jimage/ImageLocationTest.java

+                () -> ImageLocation.getFlags("/packages/pkgname", p -> true));
+    }
+
+    @Test


The getPackageFlags tests check that module references get merged correctly to create the parent directory flags we expect. While adding individual resources you build up a list of references in each package, one for each resource (directly or indirectly) in that package.
This is a key reason for how the new code can simplify things around the outer "add each resource in turn" loop, by just collecting the references and merging them later to get the right result.

david-beaumont · 2025-10-27T13:44:19Z

test/jdk/jdk/internal/jimage/ImageLocationTest.java

+                ModuleReference.forEmptyPackage("modbar", true),
+                ModuleReference.forEmptyPackage("modbaz", true));
+        int previewOnlyFlags = ImageLocation.getPackageFlags(refs);
+        // Note the asymmetry between this and the getFlags() case. Unlike


This is a flag combination you can't see for locations in /modules, because "has-preview-version" there means "is-not-a-preview-resource" and thus cannot imply "preview only". But there is no concept of "is-a-preview-resource" for things in the /packages space.

However, the code using the flags doesn't really care about what combinations exist since the flags are designed to be used independently of each other, each answering a specific question at a certain place in the processing code.

hasPreviewVersion means:

Put this entry first so we can skip 99% of packages with no preview content during pre-processing.

isPreviewOnly means:

Don't add this to the /packages directory when not in preview mode.

Put the node for this location in the preview-only map to be added separately during directory completion (in preview mode).

david-beaumont · 2025-10-27T13:53:23Z

test/jdk/jdk/internal/jimage/ImageReaderTest.java

+            ImageClassLoader loader = new ImageClassLoader(reader, IMAGE_ENTRIES.keySet());
+
+            // Preview version of classes either overwrite existing entries or are added to directories.
+            assertEquals("Preview: com.foo.HasPreviewVersion", loader.loadAndGetToString("modfoo", "com.foo.HasPreviewVersion"));


This "load the class, run its toString() method and test the result" could be encapsulated a bit more if you think it would make the intent of the test clearer. E.g.:

assertClassToString("modfoo", "com.foo.HasPreviewVersion", "Preview: com.foo.HasPreviewVersion", loader);

Or even:

loader.assertNormalVersion("modfoo", "com.foo.NormalFoo"); loader.assertPreviewVersion("modfoo", "com.foo.HasPreviewVersion");

Thoughts?

david-beaumont · 2025-10-27T13:55:17Z

test/micro/org/openjdk/bench/jdk/internal/jrtfs/ImageReaderBenchmark.java

-            "/modules/java.base/java/util/IdentityHashMap$KeyIterator.class",
-            "/modules/java.base/java/lang/Shutdown.class",
-            "/modules/java.base/java/lang/Shutdown$Lock.class");
+    /// Note: This list is inherently a little fragile and may end up being more


Sorry about this enormous non-diff. It's because of moving the static init into a holder class because we now want "module" + "path" as two separate things, pre-calculated, for benchmarking the new APIs.

Merge jdk-26+21

… since jdk-22+8 Reviewed-by: phubner, fparain

Reviewed-by: phubner, fparain

Reviewed-by: dsimms

Reviewed-by: vromero

Reviewed-by: mhaessig, thartmann, chagedorn

Reviewed-by: cjplummer

…DK-8350550 Reviewed-by: coleenp, fparain

…values.

* fixing tests after refactoring * Fixing up after dependent PR changes * feedback and remove unused code * new tests for ImageLocation * Restoring lost changes and updating some comments. * add system property guard to preview mode * Remove TODOs now jimage version is bumped * jimage writer changes to support preview mode.

david-beaumont changed the base branch from lworld to pr/1619 September 23, 2025 19:25

david-beaumont mentioned this pull request Sep 23, 2025

8368475: [lworld] Add preview classes to jimage at make time #1622

Open

1 task

openjdk bot added the rfr Pull request is ready for review label Sep 23, 2025

david-beaumont commented Sep 23, 2025

View reviewed changes

david-beaumont force-pushed the jdk_8368467_reader branch from 0c0ad6a to b192c84 Compare September 23, 2025 23:02

RogerRiggs reviewed Sep 29, 2025

View reviewed changes

david-beaumont commented Oct 10, 2025

View reviewed changes

TheRealMDoerr and others added 18 commits October 16, 2025 09:40

8368205: [TESTBUG] VectorMaskCompareNotTest.java crashes when MaxVect…

6e911d8

…orSize=8 Reviewed-by: dzhang, epeter, rrich

8369982: ProblemList jdk/jfr/jvm/TestWaste.java

d6c122b

Reviewed-by: tschatzl, dholmes

8358942: HttpClient adds Content-Length: 0 for a GET request with a B…

ead35a7

…odyPublishers.noBody() Reviewed-by: dfuchs, vyazici

8369491: Temporarily revert default TIMEOUT_FACTOR back to 4

5fc3904

Reviewed-by: lkorinth, cstein, jpai, syan, serb, prr

8369505: jhsdb jstack cannot handle continuation stub

1653999

Reviewed-by: cjplummer, pchilanomate

8368950: RISC-V: fail to catch out of order declarations among depend…

f475eb8

…ent cpu extensions/flags Reviewed-by: fyang, luhenry

8369912: [TESTBUG] testlibrary_tests/template_framework/examples/Test…

5dfe115

…Expressions.java fails with ArithmeticException: / by zero - forgot to respect Expression.info Reviewed-by: kvn, mhaessig

8369804: TestGenerators.java fails with IllegalArgumentException: bou…

f2a9983

…nd must be greater than origin Reviewed-by: chagedorn, thartmann

8369573: Add missing compile commands help documentation for the sign…

303eb10

…ature part of method patterns Reviewed-by: rcastanedalo, aseoane, thartmann

8183336: Better cleanup for jdk/test/java/lang/module/customfs/Module…

87092ef

…sInCustomFileSystem.java Reviewed-by: alanb, syan

8362637: Convert java.nio.ByteOrder to an enum

95380e1

Reviewed-by: alanb, liach, bpb

8369232: testlibrary_tests/ir_framework/tests/TestScenariosCrossProdu…

e56db37

…ct.java timed out Reviewed-by: dfenacci, epeter

8369858: Remove darcy author tags from jdk tests

7e03240

Reviewed-by: rriggs, iris, lancea

8369451: Debug agent support for USE_ITERATE_THROUGH_HEAP is broken a…

873666d

…nd should be removed Reviewed-by: sspitsyn, amenkov

8364673: Remove duplicate font mapping for itcavantgarde in psfontj2d…

d7b525a

….properties Reviewed-by: azvegint, kizune

8369146: java/awt/PrintJob/GetGraphicsTest.java: Parse Exception: Inv…

844118a

…alid or unrecognized bugid: 50510568367702 Reviewed-by: syan, azvegint, kizune, jdv

8367709: GenShen: Dirty cards for objects that get promoted by safepo…

d447297

…int that intervenes between allocation and stores Reviewed-by: ysr

8355752: Bump minimum boot jdk to JDK 25

9589a29

Reviewed-by: darcy, shade, ihse, iris

openjdk bot removed the merge-conflict Pull request has merge conflict with target branch label Oct 27, 2025

david-beaumont commented Oct 27, 2025

View reviewed changes

David Simms and others added 23 commits October 27, 2025 16:48

Merge jdk

8cf3b7a

Merge jdk-26+21

8314996: [lworld] java/lang/Thread/virtual/stress/PingPong.java fails…

c3b382e

… since jdk-22+8 Reviewed-by: phubner, fparain

8370509: [lworld] EnableValhalla is not needed for sync

ba1a305

Reviewed-by: phubner, fparain

Problem list compiler/valhalla/inlinetypes/TestNullableArrays.java

8bd522b

Reviewed-by: dsimms

8370687: Improve before constructor has been called error message

ef11682

Reviewed-by: vromero

8369530: [lworld] Improve execution time of compiler tests

cf32b27

Reviewed-by: mhaessig, thartmann, chagedorn

8367711: [lworld] JDI test updates

8ad1f11

Reviewed-by: cjplummer

8370217: [lworld] Crash in add_migrated_value_classes after merging J…

a60678c

…DK-8350550 Reviewed-by: coleenp, fparain

Java ImageReader changes for preview mode

90c4979

Clarifying flag docs for /packages/xxx case

2cad494

Add workaround until new image writing code is in

2a26c69

[[AUTOMATIC FORMATTING]]

644d2e2

Word smithing flags definitions.

0242d5a

Fixing unit tests to use new constructor.

b6031ec

Renaming slightly confusing "testEncoder" method.

dc319e3

Feedback changes, and fixing some comments.

b1b534c

Changing existing package flags during writing to match altered flag …

0ce3451

…values.

[[AUTOMATIC FORMATTING]]

8f945ed

Removing package root flag based on feedback.

94f93a2

feedback changes

9ef350a

Reapplying feedback changes.

05b4dd5

remove preview only entries when completing directories

b211c23

david-beaumont force-pushed the jdk_8368467_reader branch from 897de83 to 6ee44b1 Compare October 31, 2025 14:54

david-beaumont closed this Oct 31, 2025

david-beaumont deleted the jdk_8368467_reader branch October 31, 2025 14:55

david-beaumont restored the jdk_8368467_reader branch October 31, 2025 14:55

8368467: [lworld] Add new flag generation for jimage to support preview mode #1621

8368467: [lworld] Add new flag generation for jimage to support preview mode #1621

Conversation

david-beaumont commented Sep 23, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Integration blocker

Issue

Reviewing

Uh oh!

bridgekeeper bot commented Sep 23, 2025

Uh oh!

openjdk bot commented Sep 23, 2025

Uh oh!

mlbridge bot commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

openjdk bot commented Sep 23, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

openjdk bot commented Oct 10, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

openjdk bot commented Oct 27, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

51 participants

david-beaumont commented Sep 23, 2025 •

edited by openjdk bot

Loading

mlbridge bot commented Sep 23, 2025 •

edited

Loading